Fix Bug with Ion Text<>Binary Conversion#335
Open
rmarrowstone wants to merge 2 commits intomasterfrom
Open
Conversation
This change fixes a bug in the Ion Text<>Binary conversion where an Ion stream of multiple top-level values would be transcoded as an Ion list. In the process of fixing it I cleaned up all of the Format comparisons to be identity of enum constant instead of string comparison of value. This is a lot more succinct and avoid helps to avoid typo errors.
cheqianh
approved these changes
Jan 11, 2024
* Removed TODO that was acted on * Removed superfluous lazy loading and wrapping in test
tgregg
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the Ion Text<>Binary conversion where
an Ion stream of multiple top-level values would be transcoded as
an Ion list.
In the process of fixing it I cleaned up all of the Format comparisons
to be identity of enum constant instead of string comparison of value.
This is a lot more succinct and avoid helps to avoid typo errors.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.